Maor Lipchuk has posted comments on this change. Change subject: core: unify and move Disk Comparators ......................................................................
Patch Set 6: (1 inline comment) .................................................... Commit Message Line 10: manner. Line 11: Line 12: 1. Moved DiskImageByDiskAliasComparator from the dal module to the Line 13: common module, so it could be shared between modules. Line 14: 2. Removed ImagesComparerByName which had exactly the same It was not removed Line 15: functionality as DiskImageByDiskAliasComparator, and used it Line 16: instead. Line 17: 3. Converted DiskImageByBootComparator to be an inline class of Line 18: VmInfoBuilderBase, as it seems useless outside it -- To view, visit http://gerrit.ovirt.org/13849 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ide5808ba4404d141f43911945e19f170e9694da4 Gerrit-PatchSet: 6 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Laszlo Hornyak <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
