Allon Mureinik has posted comments on this change.
Change subject: findbugs: Method with Boolean return explicit null
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/plugin/jsni/JsFunctionResultHelper.java
Line 147: }, errorHandler);
Line 148: }
Line 149:
Line 150: public Boolean getResultAsBoolean() {
Line 151: return JsFunction.RESULT_TYPE_BOOLEAN.equals(resultType) ?
(Boolean) resultValue : Boolean.FALSE;
The only place that uses this function is
org.ovirt.engine.ui.webadmin.plugin.jsni.JsFunctionResultHelper.invokeAndGetResultAsBoolean(JsFunction,
JsArray<?>, ErrorHandler, boolean)
By tracking back the call stack to updateActionButtonCommand, it seems that if
null is returned from getResultAsBoolean, you should return true and not false.
Line 152: }
Line 153:
--
To view, visit http://gerrit.ovirt.org/14227
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibe28d8e00e2597cdbfd59c0acbb3c7dd8d08c99a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
