Shahar Havivi has uploaded a new change for review. Change subject: findbugs: equals between different types ......................................................................
findbugs: equals between different types Change-Id: I125e5df8def7a223f9469decc7aa43dab61f4a47 Signed-off-by: Shahar Havivi <[email protected]> --- M backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQueryTest.java 1 file changed, 5 insertions(+), 5 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/96/14296/1 diff --git a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQueryTest.java b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQueryTest.java index a33860c..b1c79c0 100644 --- a/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQueryTest.java +++ b/backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/DiskStatisticalQueryTest.java @@ -47,19 +47,19 @@ } private void verifyStatistic(Statistic statistic) { - if (statistic.getName().equals(DiskStatisticalQuery.DATA_READ)) { + if (statistic.equals(DiskStatisticalQuery.DATA_READ)) { assertEquals(statistic.getValues().getValues().get(0).getDatum().intValue(), READ_RATE); } - if (statistic.getName().equals(DiskStatisticalQuery.DATA_WRITE)) { + if (statistic.equals(DiskStatisticalQuery.DATA_WRITE)) { assertEquals(statistic.getValues().getValues().get(0).getDatum().intValue(), WRITE_RATE); } - if (statistic.getName().equals(DiskStatisticalQuery.READ_LATENCY)) { + if (statistic.equals(DiskStatisticalQuery.READ_LATENCY)) { assertEquals(statistic.getValues().getValues().get(0).getDatum().doubleValue(), READ_LATENCY, EPSILON); } - if (statistic.getName().equals(DiskStatisticalQuery.WRITE_LATENCY)) { + if (statistic.equals(DiskStatisticalQuery.WRITE_LATENCY)) { assertEquals(statistic.getValues().getValues().get(0).getDatum().doubleValue(), WRITE_LATENCY, EPSILON); } - if (statistic.getName().equals(DiskStatisticalQuery.FLUSH_LATENCY)) { + if (statistic.equals(DiskStatisticalQuery.FLUSH_LATENCY)) { assertEquals(statistic.getValues().getValues().get(0).getDatum().doubleValue(), FLUSH_LATENCY, EPSILON); } } -- To view, visit http://gerrit.ovirt.org/14296 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I125e5df8def7a223f9469decc7aa43dab61f4a47 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
