Michael Kublin has posted comments on this change. Change subject: core: inactive domain can be selected as master ......................................................................
Patch Set 5: "The patch will cause insufficient reconstructs in 99%" - in which cases? can you please give example for such case? Always, when all domains in inActive status and all host connected to pool. This is standard case of failover and I suppose this a first case that you should check in your environment, before sending a patch and putting +1 in Verified. "Idea is wrong, why? If no Active/Unknown domain in pool, meaning we have not any host that can see it, no reason for reconstruct" - that's exactly the issue, when hosts aren't connected to the pool - we can't recover the domains from being inactive to be active - the behaviour that we want in the system is to attempt to reconstruct to those inactive domains. - You read a code ? Connect is send only from spm election or InitVds on up, if host is in status Up connect will be send only in case that host is selected as SPM, again basics. "If host is not connected to pool or failed to connect, during spm election we can trigger a reconstruct on InActive domains, but code should look differently" - I don't agree, reconstruct is triggered from irs commands when we get IRSNoMasterDomainException, the logic is to first reconstruct to active/unknown domains and only if there's not such one attempt to do it for inactive domains - the fact that the same master can't be chosen to be reconstructed to is another issue that we have unrelated to this change. - Your patch should solve all issues, when you writing a patch that opens a new issues, which actually a direct result of your patch, because like I said your patch is not 100% correct... Like I said, the following flow is simple, all complexity is caused by code, after making code simple most problems will be resolved. I don't see any reason to write a code which is contains workarounds and some assumptions. -- To view, visit http://gerrit.ovirt.org/13160 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I9031e2fe0afc161c1a3acdddc9b1e7a58626a159 Gerrit-PatchSet: 5 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Liron Ar <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Michael Kublin <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
