Martin Beták has posted comments on this change.
Change subject: webadmin: Correct timezone default in New/Edit VM dialog
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 83: select fn_db_add_config_value('DebugTimerLogging','true','general');
Line 84: select
fn_db_add_config_value('DefaultMaxThreadPoolSize','500','general');
Line 85: select
fn_db_add_config_value('DefaultMinThreadPoolSize','50','general');
Line 86: select fn_db_add_config_value('DefaultTimeZone','(GMT) GMT Standard
Time','general');
Line 87: select
fn_db_add_config_value('DefaultGeneralTimeZone','Etc/GMT','general');
Well windows uses different set of timezones than java (which is used for linux
and other type OS) and the class capable of translating between these two
org.ovirt.engine.api.common.util.TimeZoneMapping is not available in the
frontend. Maybe we could do the translation in GetDefualtTimeZoneQuery but then
there is the question whether the entry in db should use windows format or java
format (general) of the timezone. I thought about renaming the existing
DefaultTimeZone -> DefaultWindowsTimeZone but wouldn't that break backward
compatibility?
Line 88: --Handling Default Workgroup
Line 89: select
fn_db_add_config_value('DefaultWorkgroup','WORKGROUP','general');
Line 90: select
fn_db_add_config_value('DesktopAudioDeviceType','WindowsXP,ac97,RHEL4,ac97,RHEL3,ac97,Windows2003x64,ac97,RHEL4x64,ac97,RHEL3x64,ac97,OtherLinux,ac97,Other,ac97,default,ich6','3.0');
Line 91: select
fn_db_add_config_value('DesktopAudioDeviceType','WindowsXP,ac97,RHEL4,ac97,RHEL3,ac97,Windows2003x64,ac97,RHEL4x64,ac97,RHEL3x64,ac97,OtherLinux,ac97,Other,ac97,default,ich6','3.1');
--
To view, visit http://gerrit.ovirt.org/14248
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaccb31f5634c16583004a79b9b47b83ff994088a
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Beták <[email protected]>
Gerrit-Reviewer: Martin Beták <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
