Daniel Erez has posted comments on this change.
Change subject: webadmin,userportal: Support column resizing for all tables
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/widget/editor/EntityModelCellTable.java
Line 302: @Override
Line 303: public void addColumn(Column column, SafeHtml headerHtml) {
Line 304: super.addColumn(column, headerHtml);
Line 305: }
Line 306:
as it's an infra patch, it might be appropriate to add here the new 'addColumn'
signature that Alona introduced in http://gerrit.ovirt.org/#/c/14366/
[addColumn(Column column, SafeHtml headerHtml, String width)]
Line 307: @Override
Line 308: public void addColumn(Column column, String headerString, String
width) {
Line 309: super.addColumn(column, headerString);
Line 310: super.setColumnWidth(column, width);
--
To view, visit http://gerrit.ovirt.org/14341
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic69b597d7c5f2330cef5a93bc8812494af731734
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
