Daniel Erez has posted comments on this change.
Change subject: webadmin: User Event Notification dialog element IDs
......................................................................
Patch Set 2: Looks good to me, approved
(1 inline comment)
Please address Alex's comments before merging.
....................................................
File
frontend/webadmin/modules/gwt-common/src/main/java/org/ovirt/engine/ui/common/utils/ElementIdUtils.java
Line 68: }
Line 69:
Line 70: private static <M extends TreeNodeModel<?, M>> int
getRootNodeIndex(M node, List<M> rootNodes) {
Line 71: for (M root : rootNodes) {
Line 72: if (node == root) {
not sure how relevant since we probably shouldn't lose reference in this flow.
Line 73: return rootNodes.indexOf(root);
Line 74: }
Line 75: }
Line 76: if (node.getParent() != null) {
--
To view, visit http://gerrit.ovirt.org/14048
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icf18b0080fffe6ba3886736a605f53570889bf3a
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Vojtech Szocs <[email protected]>
Gerrit-Reviewer: Alexander Wels <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Einav Cohen <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vojtech Szocs <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
