Hello Sahina Bose,
I'd like you to do a code review. Please visit
http://gerrit.ovirt.org/14381
to review the following change.
Change subject: restapi:Correct rsdl for add bricks
......................................................................
restapi:Correct rsdl for add bricks
Add bricks command causes an exception in cli
when passed a collection of bricks.
Changed the rsdl to brick--COLLECTION
as per Michael's suggestion
Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798
Bug-Url: https://bugzilla.redhat.com/923169
Signed-off-by: Sahina Bose <[email protected]>
---
M
backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
1 file changed, 15 insertions(+), 16 deletions(-)
git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/81/14381/1
diff --git
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
index c9b0431..1072c74 100644
---
a/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
+++
b/backend/manager/modules/restapi/interface/definition/src/main/resources/rsdl_metadata.yaml
@@ -8,7 +8,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -618,7 +618,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -770,7 +770,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -895,7 +895,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -1052,7 +1052,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -1204,7 +1204,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -1221,7 +1221,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -1256,7 +1256,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -1468,7 +1468,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -1828,7 +1828,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -2048,7 +2048,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -2314,7 +2314,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
headers: {}
@@ -2497,7 +2497,7 @@
body:
parameterType: null
signatures: []
- urlparams:
+ urlparams:
search: {context: query, type: 'xs:string', value: 'search query',
required: false}
case_sensitive: {context: matrix, type: 'xs:boolean', value: true|false,
required: false}
max: {context: matrix, type: 'xs:int', value: 'max results', required:
false}
@@ -2694,9 +2694,8 @@
parameterType: Bricks
signatures:
- mandatoryArguments:
- bricks.brick--COLLECTION: {brick.server_id: 'xs:string',
brick.brick_dir: 'xs:string'}
- optionalArguments:
- bricks.brick--COLLECTION: {brick.replica_count: 'xs:unsignedShort',
brick.stripe_count: 'xs:unsignedShort'}
+ brick--COLLECTION: {brick.server_id: 'xs:string', brick.brick_dir:
'xs:string'}
+ optionalArguments: {replica_count: 'xs:unsignedShort', stripe_count:
'xs:unsignedShort'}
urlparams: {}
headers:
Content-Type: {value: application/xml|json, required: true}
--
To view, visit http://gerrit.ovirt.org/14381
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I2a229faa90c8fcded33b53ab8801c4cb03094798
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: engine_3.2
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
