Ravi Nori has posted comments on this change.
Change subject: cli: Add brick operation fails from ovirt-shell(#923169)
......................................................................
Patch Set 5: (1 inline comment)
....................................................
File src/ovirtcli/command/command.py
Line 96: return param
Line 97:
Line 98: def __do_set_data(self, obj, prop, fq_prop, val):
Line 99: """INTERNAL: set data in to object based on 'prop' map
segmentation"""
Line 100: if prop.find('-') != -1 or (len(prop) > 0 and
len(prop.split('-')) == 1 and hasattr(obj, prop)):
Ok will remove len(prop.split('-')) == 1 , it is redundant
Line 101: props = prop.split('-')
Line 102: props_len = len(props)
Line 103:
Line 104: for i in range(props_len):
--
To view, visit http://gerrit.ovirt.org/13756
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia42557b26dbaacb0a00da461e07dae60fee4ae5e
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine-cli
Gerrit-Branch: master
Gerrit-Owner: Ravi Nori <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
