Allon Mureinik has uploaded a new change for review. Change subject: core: Fix testGetRootDSENoServers ......................................................................
core: Fix testGetRootDSENoServers Since urls is a zero length list, urls.get(0) throws an IndexOutOfBoundsException. This exception is caught, and thus the test passes, but it's kind of meaningless - it does not execute any of the DirectorySearcher's code, and essentially tests Java's ArrayList.get(int) implementation. I guess it's safe to assume that it works correctly. Change-Id: I295d9b10495efabf892107187de7ccd91334062f Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/14418/1 diff --git a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java index a6a07dd..f8df94e 100644 --- a/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java +++ b/backend/manager/modules/bll/src/test/java/org/ovirt/engine/core/bll/adbroker/DirectorySearcherTest.java @@ -99,7 +99,7 @@ List<URI> urls = new ArrayList<URI>(); DirectorySearcher dirSearcher = mockDirectorySearcher(urls); try { - GetRootDSETask getRootDSETask = new GetRootDSETask(dirSearcher, "mydomain", urls.get(0)); + GetRootDSETask getRootDSETask = new GetRootDSETask(dirSearcher, "mydomain", null); execute(getRootDSETask); } catch (Exception e) { // should fail -- To view, visit http://gerrit.ovirt.org/14418 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I295d9b10495efabf892107187de7ccd91334062f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
