Alon Bar-Lev has posted comments on this change. Change subject: pki: move configuration from vdc_options to EngineLocalConfig ......................................................................
Patch Set 8: (1 inline comment) Strange I don't see the comment of the ca.pem in gerrit... I will remove the ca.pem as the test actually tests the LocalConfig and not the PKI stuff... so if we ever want to add LocalConfig test suite, we cover this and more. Thanks! .................................................... File backend/manager/dbscripts/upgrade/03_01_1440_encrypt_chap_password.sh Line 1: #!/bin/bash Because it includes dbfunctions, which uses bashism. Line 2: Line 3: #include db general functions Line 4: source ./dbfunctions.sh Line 5: -- To view, visit http://gerrit.ovirt.org/14333 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I1764d9ca7a8c677401f721b3d89f45deff9c1f26 Gerrit-PatchSet: 8 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Barak Azulay <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Eli Mesika <[email protected]> Gerrit-Reviewer: Juan Hernandez <[email protected]> Gerrit-Reviewer: Keith Robertson <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Spenser Shumaker <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
