Tal Nisan has posted comments on this change.
Change subject: core: LexoNumericComparator to comparators pkg
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/businessentities/comparators/LexoNumericComparator.java
Line 24: @Override
Line 25: public int compare(String str1, String str2) {
Line 26: return comp(str1, str2);
Line 27: }
Line 28:
Not necessarily for this patch but this method is redundant, we can just use
compare here and avoid the call to comp
Line 29: public static int comp(String str1, String str2) {
Line 30: if (str1 == null) {
Line 31: return (str2 == null) ? 0 : -1;
Line 32: } else if (str2 == null) {
--
To view, visit http://gerrit.ovirt.org/14412
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic23f6efefb8f83a791cab38f3da43a78c5f885bb
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Lior Vernia <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
