Alon Bar-Lev has posted comments on this change.
Change subject: engine: Allow engine to configure management network
......................................................................
Patch Set 5: (2 inline comments)
Thanks!
Two questions.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/InstallVdsCommand.java
Line 143: T parameters = getParameters();
Line 144: installer = new VdsDeploy(getVds());
Line 145: installer.setCorrelationId(getCorrelationId());
Line 146: boolean configureNetwork =
!FeatureSupported.setupNetworks(getVds().getVdsGroupCompatibilityVersion());
Line 147:
installer.setReboot(parameters.isRebootAfterInstallation() && configureNetwork);
Why have you disabled reboot? I thought that this process will be done post
reboot, anyway, if it is pre-reboot, where is reboot takes place?
Line 148: if (configureNetwork) {
Line 149:
installer.setManagementNetwork(NetworkUtils.getEngineNetwork());
Line 150: }
Line 151:
Line 184: public void run() {
Line 185:
getBackend().runInternalAction(VdcActionType.ActivateVds,
Line 186: new
VdsActionParameters(getVds().getId()));
Line 187: }
Line 188: });
Won't it be better to pass a parameter here specifying that network is to be
created?
Line 189: }
Line 190: }
Line 191: log.infoFormat(
Line 192: "After Installation host {0}, {1}",
--
To view, visit http://gerrit.ovirt.org/14230
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf82e10481e595d690e7ce894283b4ed5b9b3269
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Moti Asayag <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Dan Kenigsberg <[email protected]>
Gerrit-Reviewer: Martin Pavlik <[email protected]>
Gerrit-Reviewer: Mike Kolesnik <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
