Tal Nisan has uploaded a new change for review. Change subject: findbugs: Fix fingbugs errors in edit quota model classes ......................................................................
findbugs: Fix fingbugs errors in edit quota model classes Change-Id: I79ec20031ecbb284b21dc8b3694841e0119d8ea7 Signed-off-by: Tal Nisan <[email protected]> --- M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaClusterModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaStorageModel.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java 3 files changed, 4 insertions(+), 4 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/86/14486/1 diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaClusterModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaClusterModel.java index f9d5234..f068385 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaClusterModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaClusterModel.java @@ -120,7 +120,7 @@ }); } - public boolean Validate() { + public boolean validate() { IntegerValidation intValidation = new IntegerValidation(); intValidation.setMinimum(1); getSpecificMemValue().setIsValid(true); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaStorageModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaStorageModel.java index cccff85..b56ab52 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaStorageModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/EditQuotaStorageModel.java @@ -68,7 +68,7 @@ }); } - public boolean Validate() { + public boolean validate() { IntegerValidation intValidation = new IntegerValidation(); intValidation.setMinimum(1); intValidation.setMaximum(65535); diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java index 497d94b..f6012e9 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/quota/QuotaModel.java @@ -327,7 +327,7 @@ private void onEditClusterQuota() { EditQuotaClusterModel model = (EditQuotaClusterModel) getWindow(); - if (!model.Validate()) { + if (!model.validate()) { return; } if ((Boolean) model.getUnlimitedMem().getEntity()) { @@ -347,7 +347,7 @@ private void onEditStorageQuota() { EditQuotaStorageModel model = (EditQuotaStorageModel) getWindow(); - if (!model.Validate()) { + if (!model.validate()) { return; } if ((Boolean) model.getUnlimitedStorage().getEntity()) { -- To view, visit http://gerrit.ovirt.org/14486 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I79ec20031ecbb284b21dc8b3694841e0119d8ea7 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
