Shireesh Anjal has posted comments on this change.
Change subject: engine: change mVerbs to Set (3/N)
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseAutoCompleter.java
Line 34: }
Line 35:
Line 36: protected final void acceptAll(final String[] tokens) {
Line 37: for (String token : tokens) {
Line 38: mVerbs.add(token);
Why would that be faster? I think addAll() will internally iterate over the
list and invoke the add() method, so it would actually be slower since you are
first converting the array to list before calling addAll().
Line 39: }
Line 40: }
Line 41:
Line 42: protected final void buildCompletions() {
--
To view, visit http://gerrit.ovirt.org/14406
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8d97f79e1aaf4818cc58918d19f1b0e9055d151e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
