Alissa Bonas has posted comments on this change. Change subject: frontend: Removed MailAddress class ......................................................................
Patch Set 1: (1 inline comment) .................................................... Commit Message Line 5: CommitDate: 2013-05-06 05:08:16 +0300 Line 6: Line 7: frontend: Removed MailAddress class Line 8: Line 9: The class MainAddress though it's obscure name is an email address MainAddress-->MailAddress Line 10: regex validator which has to be instantiated to validate and throws a Line 11: runtime exception if the email is invalid, this is definitely a wrong Line 12: behavior considering what we need the validator to be, the regex validation Line 13: was extracted to the class that used it in the first place - EmailValidation -- To view, visit http://gerrit.ovirt.org/14489 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I36c1f8f11d48ccfb00a9204c89828cd15c76338f Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
