Gilad Chaplik has posted comments on this change.
Change subject: engine: custom properties: allow '=' in regex
......................................................................
Patch Set 4: (1 inline comment)
....................................................
File
backend/manager/tools/src/main/java/org/ovirt/engine/core/config/entity/helper/CustomPropertiesValueHelper.java
Line 15: String[] keyValuePairs = value.split(";");
Line 16: for (int counter = 0; counter < keyValuePairs.length;
counter++) {
Line 17: String keyValuePair = keyValuePairs[counter];
Line 18: String parts[] = keyValuePair.split("=", 2);
Line 19: if (parts.length != 2) {
yes, in case there are no '=' in string
Line 20: return new ValidationResult(false,"The entered value is
in imporper format. " + keyValuePair + " cannot be used for custom properties
definition.\nA string of key=value pair should be used instead, where the value
should be a correct regex expression");
Line 21: }
Line 22: try {
Line 23: Pattern.compile(parts[1]);
--
To view, visit http://gerrit.ovirt.org/14182
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic845e2ab5a0f23d48c1506f4f834a851009ea253
Gerrit-PatchSet: 4
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Doron Fediuck <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
