Alissa Bonas has uploaded a new change for review. Change subject: core: setStorage once in AddSanStorageDomainCommand ......................................................................
core: setStorage once in AddSanStorageDomainCommand Calling setStorage once in AddSanStorageDomainCommand instead of setting it several times one after another. Change-Id: Idc63f032f274437e0ffbc14392b19e9239fcb8c0 Signed-off-by: Alissa Bonas <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java 1 file changed, 3 insertions(+), 3 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/18/14518/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java index a82db90..569d2c0 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/storage/AddSANStorageDomainCommand.java @@ -41,10 +41,10 @@ // status to be locked getStorageDomain().setStorage(""); addStorageDomainInDb(); - getStorageDomain().setStorage(storage); - if (StringUtils.isEmpty(getStorageDomain().getStorage())) { - getStorageDomain().setStorage(createVG()); + if(StringUtils.isEmpty(storage)) { + storage = createVG(); } + getStorageDomain().setStorage(storage); if (StringUtils.isNotEmpty(getStorageDomain().getStorage()) && (addStorageDomainInIrs())) { DbFacade.getInstance().getStorageDomainStaticDao().update(getStorageDomain().getStorageStaticData()); updateStorageDomainDynamicFromIrs(); -- To view, visit http://gerrit.ovirt.org/14518 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idc63f032f274437e0ffbc14392b19e9239fcb8c0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Alissa Bonas <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
