Gilad Chaplik has posted comments on this change. Change subject: findbugs: Fix fingbugs error in StorageDataCenterListModel class ......................................................................
Patch Set 1: (1 inline comment) .................................................... File frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/storage/StorageDataCenterListModel.java Line 309: dataCenter.getId()); Line 310: break; Line 311: default: Line 312: // Should never happen and even if so there is not much to do about it since the new Line 313: // data center type is not handled yet anyway Tal, there's no debate here, please refer to my comment in http://gerrit.ovirt.org/#/c/14449/1, abandon all patches, and re-factor as suggested. Line 314: break; Line 315: } Line 316: } Line 317: -- To view, visit http://gerrit.ovirt.org/14455 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I02c4c364d9bb42728fb8b024dc66a5456c0053de Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Tal Nisan <[email protected]> Gerrit-Reviewer: Alissa Bonas <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Daniel Erez <[email protected]> Gerrit-Reviewer: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Liron Ar <[email protected]> Gerrit-Reviewer: Maor Lipchuk <[email protected]> Gerrit-Reviewer: Sergey Gotliv <[email protected]> Gerrit-Reviewer: Tal Nisan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
