Gilad Chaplik has posted comments on this change.
Change subject: userportal,webadmin: implement VM builder
......................................................................
Patch Set 9: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/KernelParamsAndIdVmToVmBuilder.java
Line 7: public class KernelParamsAndIdVmToVmBuilder extends BaseSyncBuilder<VM,
VM> {
Line 8:
Line 9: @Override
Line 10: protected void build(VM source, VM destination) {
Line 11: destination.setId(source.getId());
why Id here?
Line 12: destination.setInitrdUrl(source.getInitrdUrl());
Line 13: destination.setKernelUrl(source.getKernelUrl());
Line 14: destination.setKernelParams(source.getKernelParams());
Line 15: }
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/builders/vm/MigrationSupportVmToUnitBuilder.java
Line 18: } else {
Line 19: backend.setDedicatedVmForVds(defaultHost.getId());
Line 20: }
Line 21:
Line 22: backend.setMigrationSupport((MigrationSupport)
frontend.getMigrationMode().getSelectedItem());
this is the part that should be separated to HA..builder
Line 23: backend.setUseHostCpuFlags((Boolean)
frontend.getHostCpu().getEntity());
Line 24: }
Line 25:
--
To view, visit http://gerrit.ovirt.org/13915
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I54d938896e469c73800297c3d66185a439243a41
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tomas Jelinek <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Tomas Jelinek <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
