Tal Nisan has posted comments on this change.
Change subject: findbugs: Fix inner class should be static warnings in
uicommonweb project
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddClusterRM.java
Line 93: cluster.setdescription((String)
clusterModel.getDescription().getEntity());
Line 94:
cluster.setStoragePoolId(enlistmentContext.getDataCenterId());
Line 95: cluster.setcpu_name(((ServerCpu)
clusterModel.getCPU().getSelectedItem()).getCpuName());
Line 96:
cluster.setmax_vds_memory_over_commit(clusterModel.getMemoryOverCommit());
Line 97:
cluster.setCountThreadsAsCores(Boolean.TRUE.equals(clusterModel.getVersionSupportsCpuThreads().getEntity())
The point of the patches is better, cleaner code, removing unnecessary casts
falls into that definition
Line 98: &&
Boolean.TRUE.equals(clusterModel.getCountThreadsAsCores().getEntity()));
Line 99: cluster.setTransparentHugepages(version.compareTo(new
Version("3.0")) >= 0); //$NON-NLS-1$
Line 100: cluster.setcompatibility_version(version);
Line 101:
cluster.setMigrateOnError(clusterModel.getMigrateOnErrorOption());
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/hosts/AddDataCenterRM.java
Line 390: // }
Line 391: // }
Line 392: //
Line 393: // enlistment.Done();
Line 394: // }
Will do
Line 395:
Line 396: private final Context context = new Context();
Line 397:
Line 398: public static final class Context {
--
To view, visit http://gerrit.ovirt.org/14479
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I60bc3fb1951b91c60b26241c0a14e7bf9facc133
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
