Gilad Chaplik has posted comments on this change.
Change subject: findbugs: use StringBuilder in a for loop
......................................................................
Patch Set 6: Looks good to me, approved
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/validation/CustomPropertyValidation.java
Line 95: {
Line 96: parameters.append(keyValue.substring(0,
keyValue.indexOf('='))).append(", "); //$NON-NLS-1$
Line 97: }
Line 98: if (parameters.length() >= 2) {
Line 99:
parameters.delete(parameters.length()-2,parameters.length()-1);
please format while rebasing
Line 100: }
Line 101:
Line 102: String reasonStr =
Line 103: ConstantsManager.getInstance()
--
To view, visit http://gerrit.ovirt.org/14367
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If11e9b335a741aaa364893474573d226ca9ece72
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
