Allon Mureinik has posted comments on this change.
Change subject: core: remove vm - remove end method code
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveAllVmImagesCommand.java
Line 46: mImagesToBeRemoved.add(image.getImageId());
Line 47: }
Line 48: }
Line 49:
Line 50: Collection<DiskImage> failedToBeRemoved = new LinkedList<>();
s/failedToBeRemoved/failedRemoving/
Line 51: for (final DiskImage image : images) {
Line 52: if (mImagesToBeRemoved.contains(image.getImageId())) {
Line 53: VdcReturnValueBase vdcReturnValue =
Line 54:
Backend.getInstance().runInternalAction(VdcActionType.RemoveImage,
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/RemoveVmCommand.java
Line 94: return null;
Line 95: }
Line 96: });
Line 97:
Line 98: if (getParameters().isRemoveDisks() && hasImages) {
why do I need to check hasImages() here?
optimization?
Line 99: Collection<DiskImage> unremovedDisks =
(Collection<DiskImage>)removeVmImages(diskImages).getActionReturnValue();
Line 100: if (!unremovedDisks.isEmpty()) {
Line 101: processUnremovedDisks(unremovedDisks);
Line 102: setSucceeded(false);
--
To view, visit http://gerrit.ovirt.org/14569
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7a3e497e52471f7255e6c17b59a2e3bf362b8783
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
