Gilad Chaplik has posted comments on this change.
Change subject: findbugs: String comparison is not using equals method
......................................................................
Patch Set 9: Looks good to me, approved
(3 inline comments)
acked.
please address minor comments while rebasing.
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskGeneralModel.java
Line 84: }
Line 85:
Line 86: public void setLunId(String value)
Line 87: {
Line 88: if (!privateLunId.equals(value))
nullity check here too :)
Line 89: {
Line 90: privateLunId = value;
Line 91: onPropertyChanged(new PropertyChangedEventArgs("LUN ID"));
//$NON-NLS-1$
Line 92: }
Line 100: }
Line 101:
Line 102: public void setQuotaName(String value)
Line 103: {
Line 104: if (!privateQuotaName.equals(value))
nullity check here too :)
Line 105: {
Line 106: privateQuotaName = value;
Line 107: onPropertyChanged(new PropertyChangedEventArgs("Quota
Name")); //$NON-NLS-1$
Line 108: }
....................................................
File
frontend/webadmin/modules/webadmin/src/main/java/org/ovirt/engine/ui/webadmin/section/main/view/tab/quota/SubTabQuotaClusterView.java
Line 37:
Line 38: getTable().addColumn(new
TextColumnWithTooltip<QuotaVdsGroup>() {
Line 39: @Override
Line 40: public String getValue(QuotaVdsGroup object) {
Line 41: return object.getVdsGroupName() == null ||
object.getVdsGroupName().equals("") ?
consider invoking 'equals' on empty str ("")
Line 42: constants.ultQuotaForAllClustersQuotaPopup() :
object.getVdsGroupName();
Line 43: }
Line 44: },
Line 45: constants.nameCluster(),
--
To view, visit http://gerrit.ovirt.org/14199
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I740261ed3383e147928505ea53edc19e2996ce69
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Asaf Shakarchi <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
