Yair Zaslavsky has posted comments on this change. Change subject: core: Removed AddVmAndCloneImageCommand ......................................................................
Patch Set 1: I would suggest that when class is removed, please go to the developer who developed the class (that would be... me) and ask him, or add him as reviewer. We were lucky that Omer guided me about AddVmFromSnapshot so he caught this. However, I would like to state I do not have any special sentiments to pieces of code I write, I just want all of us to have the full picture - This class was created as base class , due to similarities between AddVmFromTemplate and AddVmFromSnapshot. We/I Did intend to complete the hierarchy/code-reuse. Unfortunately, due to time constraints on 3.1, this was never accomplished. Omer actually was in favor of tasking this one step even further towards having just one AddVm class , but IMHO this is a good interim step. If we do want to push this further (+ if we have time) and still Reuse code (and have less code at AddVmFromTemplate and AddVmFromSnapshot) it would be great. It's up to virt/storage to decide -- To view, visit http://gerrit.ovirt.org/14572 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I3cfbeeef8c15b8747ccb5e123ae171e599290e0b Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Vered Volansky <[email protected]> Gerrit-Reviewer: Allon Mureinik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Roy Golan <[email protected]> Gerrit-Reviewer: Vered Volansky <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
