Eli Mesika has posted comments on this change.
Change subject: packaging: updated loading of validator sp functions
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File backend/manager/tools/dbutils/fkvalidator.sh
Line 86: h) ret=0 && usage;;
Line 87: \?) ret=1 && usage;;
Line 88: esac
Line 89: done
Line 90:
This deletion breaks the script in case that fkvalidator.sh is executed
manually in a db that does not have the SPs installed
Line 91: if [[ "${FIXIT}" = "true" && ! "${QUIET}" = "true" ]]; then
Line 92: echo "Caution, this operation should be used with care. Please
contact support prior to running this command"
Line 93: echo "Are you sure you want to proceed? [y/n]"
Line 94: read answer
--
To view, visit http://gerrit.ovirt.org/14603
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9f133fd43441a42c1d5817ed5bfbc6262123df4
Gerrit-PatchSet: 2
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Eyal Edri <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
