Tal Nisan has posted comments on this change.
Change subject: findbugs: Fix fingbugs errors in ClusterListModel class
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterListModel.java
Line 290: setAsyncResult(Frontend.RegisterSearch(getSearchString(),
SearchType.Cluster, getSearchPageSize()));
Line 291: setItems(getAsyncResult().getData());
Line 292: }
Line 293:
Line 294: public void newCluster()
Why do we need it to be the same in ALL models if it's not defined in a base
class or interface?
If I'm bound to super method of a base class or interface I'll use generic
names such as new or edit, but if it is a regular class method I will prefer a
more descriptive name, the method is for new cluster thus newCluster is better
and more intuitive than newEntity, why would I want obscure names unless I have
to?
Line 295: {
Line 296: if (getWindow() != null)
Line 297: {
Line 298: return;
--
To view, visit http://gerrit.ovirt.org/14482
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I494e0a984540378fa90321da9a503f6296bec198
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
