Oved Ourfali has posted comments on this change. Change subject: core: empty role shouldn't be valid ......................................................................
Patch Set 1: Are you sure the login action group isn't shown to the user? afaik it is shown. I also don't think we should mind what action groups he chose, and whether he didn't choose anything. Even if the login action group isn't shown, it makes sense that users who have this new role will be able to login, as a base line role, and in the future they are granted other roles, according to what they should see/do. -- To view, visit http://gerrit.ovirt.org/14586 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic6826e5a9765c4280ba73c31fd93137a228e3c52 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> Gerrit-Reviewer: Omer Frenkel <[email protected]> Gerrit-Reviewer: Oved Ourfali <[email protected]> Gerrit-Reviewer: Yair Zaslavsky <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
