Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs errors in CommonModel class
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/CommonModel.java
Line 349: }
Line 350:
Line 351: static
Line 352: {
Line 353: signedOutEventDefinition = new EventDefinition("SignedOut",
CommonModel.class); //$NON-NLS-1$
I'd move this to the member's definition while you're at it - it makes it
easier to understand.
Line 354: }
Line 355:
Line 356: private static CommonModel instance = null;
Line 357:
--
To view, visit http://gerrit.ovirt.org/14469
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5c70235fe828c1d662813773312c6529101e0a2b
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Laszlo Hornyak <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
