Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs errors in EntityModel class
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/EntityModel.java
Line 13: @SuppressWarnings("unused")
Line 14: public class EntityModel extends Model
Line 15: {
Line 16:
Line 17: final public static EventDefinition entityChangedEventDefinition;
Should actually be public static final
Line 18: private Event privateEntityChangedEvent;
Line 19:
Line 20: public Event getEntityChangedEvent()
Line 21: {
Line 69: }
Line 70:
Line 71: static
Line 72: {
Line 73: entityChangedEventDefinition = new
EventDefinition("EntityChanged", EntityModel.class); //$NON-NLS-1$
I'd move this to the member's definition while I'm at it.
Line 74: }
Line 75:
Line 76: public EntityModel()
Line 77: {
--
To view, visit http://gerrit.ovirt.org/14471
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I22664795e8f38628216f167978051f4c8c1ea81d
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
