Allon Mureinik has posted comments on this change.
Change subject: findbugs: Fix fingbugs errors in system tree models classes
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(2 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/SystemTreeModel.java
Line 35: @SuppressWarnings("unused")
Line 36: public class SystemTreeModel extends SearchableListModel implements
IFrontendMultipleQueryAsyncCallback
Line 37: {
Line 38:
Line 39: public final static EventDefinition resetRequestedEventDefinition;
should actually be public static final
Line 40: private Event privateResetRequestedEvent;
Line 41:
Line 42: public Event getResetRequestedEvent()
Line 43: {
Line 162: }
Line 163:
Line 164: static
Line 165: {
Line 166: resetRequestedEventDefinition = new
EventDefinition("ResetRequested", SystemTreeModel.class); //$NON-NLS-1$
I'd inline this with the member's definition while you're at it
Line 167: }
Line 168:
Line 169: public SystemTreeModel()
Line 170: {
--
To view, visit http://gerrit.ovirt.org/14474
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia4821d7365cc26c09c60378a252c9cd9a38f51c5
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
