Allon Mureinik has posted comments on this change.
Change subject: findbugs: Remove dead local storage in uicommonweb project
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(7 inline comments)
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/clusters/ClusterGuideModel.java
Line 360: {
Line 361:
Frontend.RunAction(VdcActionType.ApproveVds,
Line 362: new
ApproveVdsParameters(selectedHost.getId()));
Line 363: }
Line 364: i++;
I'd do this in a different patch - it's a logic fix
Line 365: }
Line 366: }
Line 367: clusterGuideModel.getWindow().stopProgress();
Line 368: clusterGuideModel.Cancel();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/configure/roles_ui/RoleListModel.java
Line 512: return;
Line 513: }
Line 514:
Line 515: // Check name unicitate.
Line 516: // String name = (String) model.getName().getEntity();
agree - just remove it (and the rest of the commented out block, while you're
at it)
Line 517: // if (!DataProvider.IsRoleNameUnique(name) &&
name.compareToIgnoreCase(role.getname()) != 0)
Line 518: // {
Line 519: // model.getName().setIsValid(false);
Line 520: // model.getName().getInvalidityReasons().add("Name must be
unique.");
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/datacenters/DataCenterGuideModel.java
Line 1521: null,
Line 1522: this);
Line 1523: }
Line 1524: i++;
Line 1525: }
I'd do this in a separate patch - it's a logic fix
Line 1526: }
Line 1527:
dataCenterGuideModel.getWindow().stopProgress();
Line 1528: dataCenterGuideModel.Cancel();
Line 1529: dataCenterGuideModel.PostAction();
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskStorageListModel.java
Line 76: UpdateActionAvailability();
Line 77: }
Line 78:
Line 79: private void UpdateActionAvailability()
Line 80: {
Agree - just remove this method
Line 81: }
Line 82:
Line 83: @Override
Line 84: protected String getListName() {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskTemplateListModel.java
Line 81: UpdateActionAvailability();
Line 82: }
Line 83:
Line 84: private void UpdateActionAvailability()
Line 85: {
agree, just remove the method
Line 86: }
Line 87:
Line 88: @Override
Line 89: protected String getListName() {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/disks/DiskVmListModel.java
Line 89: UpdateActionAvailability();
Line 90: }
Line 91:
Line 92: private void UpdateActionAvailability()
Line 93: {
agree, just remove the method
Line 94: }
Line 95:
Line 96: @Override
Line 97: protected String getListName() {
....................................................
File
frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/vms/VmModelBehaviorBase.java
Line 615: ArrayList<StorageDomain> activeDiskStorageDomains
=
Line 616: Linq.getStorageDomainsByIds(storageIds,
activeStorageDomains);
Line 617:
Line 618: // Set target storage domains
Line 619: ArrayList<StorageDomain>
availableDiskStorageDomains =
Dumb question - is List (as opposed to ArrayList) allowed in GWT code?
Line 620: provisioning ? activeStorageDomains :
activeDiskStorageDomains;
Line 621: Linq.sort(availableDiskStorageDomains, new
Linq.StorageDomainByNameComparer());
Line 622:
diskModel.getStorageDomain().setItems(availableDiskStorageDomains);
Line 623:
--
To view, visit http://gerrit.ovirt.org/14475
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1afe4e408b6a4f1b652a710369250c9ddb3d2ca7
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Tal Nisan <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Gilad Chaplik <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
