Shahar Havivi has posted comments on this change.
Change subject: findbugs: Comparing integer by its reference value
......................................................................
Patch Set 7: (1 inline comment)
....................................................
File
backend/manager/modules/restapi/jaxrs/src/test/java/org/ovirt/engine/api/restapi/resource/BackendCapabilitiesResourceTest.java
Line 362: private boolean greaterOrEqual(Version a, Version b) {
Line 363: int aMajor = a.getMajor() == null ? 0 :
a.getMajor().intValue();
Line 364: int aMinor = a.getMinor() == null ? 0 :
a.getMinor().intValue();
Line 365: int bMajor = b.getMajor() == null ? 0 :
b.getMajor().intValue();
Line 366: int bMinor = b.getMinor() == null ? 0 :
b.getMinor().intValue();
Sorry, I don't see it twice.
What do you mean?
Line 367: return aMajor != bMajor ? aMajor >= bMajor : aMinor >= bMinor;
Line 368: }
Line 369:
Line 370: @Override
--
To view, visit http://gerrit.ovirt.org/14570
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If780c1f44b1750dba343831e58f866359eded941
Gerrit-PatchSet: 7
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shahar Havivi <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michael Pasternak <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Shahar Havivi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
