Gilad Chaplik has uploaded a new change for review. Change subject: searchBackend: rename methods to begin with lowercase letter ......................................................................
searchBackend: rename methods to begin with lowercase letter Although a method name can be any legal identifier, code conventions restrict method names. By convention, method names should be a verb in lowercase or a multi-word name that begins with a verb in lowercase. Change-Id: I2d66cc1682b6855d8d17554bf05e2778d8e377e8 Signed-off-by: Gilad Chaplik <[email protected]> --- M backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleter.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java M backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java M backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java M frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java 7 files changed, 20 insertions(+), 20 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/49/14649/1 diff --git a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java index 1e6db03..d554ffe 100644 --- a/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java +++ b/backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/SearchQuery.java @@ -318,11 +318,11 @@ String domain = getDefaultDomain(); data.setDomain(domain); } - curSyntaxChecker = SyntaxCheckerFactory.CreateADSyntaxChecker(Config + curSyntaxChecker = SyntaxCheckerFactory.createADSyntaxChecker(Config .<String> getValue(ConfigValues.AuthenticationMethod)); } else { curSyntaxChecker = SyntaxCheckerFactory - .CreateBackendSyntaxChecker(Config.<String> getValue(ConfigValues.AuthenticationMethod)); + .createBackendSyntaxChecker(Config.<String> getValue(ConfigValues.AuthenticationMethod)); } SyntaxContainer searchObj = curSyntaxChecker.analyzeSyntaxState(searchText, true); // set the case-sensitive flag diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java index 10b51cd..6bc31f7 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/BaseConditionFieldAutoCompleter.java @@ -296,7 +296,7 @@ DateTime result; if (temp == null) { - result = DealWithDateEnum(value.argvalue); + result = dealWithDateEnum(value.argvalue); } else { result = new DateTime(temp); } @@ -341,7 +341,7 @@ } // private static final String DATE_FORMAT = "MMM dd,yyyy"; - private static DateTime DealWithDateEnum(String value) { + private static DateTime dealWithDateEnum(String value) { DateTime formatedValue = new DateTime(); final Integer result = IntegerCompat.tryParse(StringHelper.trim(value, '\'')); if (result != null) { diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleter.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleter.java index 61a3c0c..ceff61b 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleter.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/DateEnumValueAutoCompleter.java @@ -14,11 +14,11 @@ mEnumValues.put(ValName, val.getValue()); mVerbs.put(ValName, ValName); } - AddDaysOfWeek(); + addDaysOfWeek(); buildCompletions(); } - private void AddDaysOfWeek() { + private void addDaysOfWeek() { String day; int dayIndex = 3; for (int i = -2; i > -8; i--) { diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java index 791bfb0..50dcde9 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactory.java @@ -13,12 +13,12 @@ // This method is for used in client side by uicommon, which cannot access // server side config, so needs to get the auth method as a parameter. - public static ISyntaxChecker CreateUISyntaxChecker(String AuthenticationMethod) { + public static ISyntaxChecker createUISyntaxChecker(String AuthenticationMethod) { ConfigAuthenticationMethod = AuthenticationMethod; return uiSyntaxChecker; } - public static ISyntaxChecker CreateBackendSyntaxChecker(String AuthenticationMethod) { + public static ISyntaxChecker createBackendSyntaxChecker(String AuthenticationMethod) { ConfigAuthenticationMethod = AuthenticationMethod; if(backendSyntaxChecker == null) { backendSyntaxChecker = new SyntaxChecker(Config.<Integer> getValue(ConfigValues.SearchResultsLimit)); @@ -26,7 +26,7 @@ return backendSyntaxChecker; } - public static ISyntaxChecker CreateADSyntaxChecker(String AuthenticationMethod) { + public static ISyntaxChecker createADSyntaxChecker(String AuthenticationMethod) { ConfigAuthenticationMethod = AuthenticationMethod; return adSyntaxChecker; } diff --git a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java index baaa034..7f02efd 100644 --- a/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java +++ b/backend/manager/modules/searchbackend/src/main/java/org/ovirt/engine/core/searchbackend/SyntaxContainer.java @@ -238,7 +238,7 @@ return sb.toString(); } - public String ToStringBr() { + public String toStringBr() { StringBuilder sb = new StringBuilder("---------------- SyntaxContainer ---------------------"); sb.append("<BR>mOrigText = "); sb.append(mOrigText); diff --git a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java index 474e279..1ddc529 100644 --- a/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java +++ b/backend/manager/modules/searchbackend/src/test/java/org/ovirt/engine/core/searchbackend/SyntaxCheckerFactoryTest.java @@ -13,26 +13,26 @@ public class SyntaxCheckerFactoryTest { @Test - public void CreateUISyntaxChecker() { - ISyntaxChecker checker = SyntaxCheckerFactory.CreateUISyntaxChecker("foo"); + public void createUISyntaxChecker() { + ISyntaxChecker checker = SyntaxCheckerFactory.createUISyntaxChecker("foo"); Assert.assertNotNull(checker); - Assert.assertEquals(checker, SyntaxCheckerFactory.CreateUISyntaxChecker("foo")); + Assert.assertEquals(checker, SyntaxCheckerFactory.createUISyntaxChecker("foo")); Assert.assertEquals("foo", SyntaxCheckerFactory.getConfigAuthenticationMethod()); } @Test - public void CreateBackendSyntaxChecker() { - ISyntaxChecker checker = SyntaxCheckerFactory.CreateBackendSyntaxChecker("foo"); + public void createBackendSyntaxChecker() { + ISyntaxChecker checker = SyntaxCheckerFactory.createBackendSyntaxChecker("foo"); Assert.assertNotNull(checker); - Assert.assertEquals(checker, SyntaxCheckerFactory.CreateBackendSyntaxChecker("foo")); + Assert.assertEquals(checker, SyntaxCheckerFactory.createBackendSyntaxChecker("foo")); Assert.assertEquals("foo", SyntaxCheckerFactory.getConfigAuthenticationMethod()); } @Test - public void CreateADSyntaxChecker() { - ISyntaxChecker checker = SyntaxCheckerFactory.CreateADSyntaxChecker("foo"); + public void createADSyntaxChecker() { + ISyntaxChecker checker = SyntaxCheckerFactory.createADSyntaxChecker("foo"); Assert.assertNotNull(checker); - Assert.assertEquals(checker, SyntaxCheckerFactory.CreateADSyntaxChecker("foo")); + Assert.assertEquals(checker, SyntaxCheckerFactory.createADSyntaxChecker("foo")); Assert.assertEquals("foo", SyntaxCheckerFactory.getConfigAuthenticationMethod()); } diff --git a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java index 8becfa8..b544ce4 100644 --- a/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java +++ b/frontend/webadmin/modules/uicommonweb/src/main/java/org/ovirt/engine/ui/uicommonweb/models/autocomplete/SearchSuggestModel.java @@ -77,7 +77,7 @@ setItems(new ObservableCollection<Object>()); syntaxChecker = - SyntaxCheckerFactory.CreateUISyntaxChecker((String) + SyntaxCheckerFactory.createUISyntaxChecker((String) AsyncDataProvider.getConfigValuePreConverted(ConfigurationValues.AuthenticationMethod)); setIsTimerDisabled(true); -- To view, visit http://gerrit.ovirt.org/14649 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I2d66cc1682b6855d8d17554bf05e2778d8e377e8 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Gilad Chaplik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
