Alon Bar-Lev has posted comments on this change.
Change subject: packaging: Validating DB encoding during setup and upgrade
......................................................................
Patch Set 9: (3 inline comments)
....................................................
File packaging/setup/plugins/ovirt-engine-setup/db/connection.py
Line 72:
Line 73: statement = database.Statement(environment=environment)
Line 74: encoding = statement.execute(
Line 75: statement="""
Line 76: show server_encoding
show is working in this mode? nice!
Line 77: """,
Line 78: ownConnection=True,
Line 79: transaction=False,
Line 80: )[0]['server_encoding']
Line 77: """,
Line 78: ownConnection=True,
Line 79: transaction=False,
Line 80: )[0]['server_encoding']
Line 81: if 'utf8' in encoding.lower():
why in and not =?
Line 82: self.logger.debug('Default encoding is UTF8')
Line 83: else:
Line 84: self.logger.debug(
Line 85: 'Default encoding is not UTF8'
Line 78: ownConnection=True,
Line 79: transaction=False,
Line 80: )[0]['server_encoding']
Line 81: if 'utf8' in encoding.lower():
Line 82: self.logger.debug('Default encoding is UTF8')
no need for this, we see the query... but if you like then the model is:
if fail:
raise exception
success block
Line 83: else:
Line 84: self.logger.debug(
Line 85: 'Default encoding is not UTF8'
Line 86: )
--
To view, visit http://gerrit.ovirt.org/14615
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I583b115cf60142cafc5ba66b0dc22e92b4807c84
Gerrit-PatchSet: 9
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Juan Hernandez <[email protected]>
Gerrit-Reviewer: Moran Goldboim <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
