Martin Peřina has posted comments on this change.
Change subject: core: WIP: Support for device custom properties
......................................................................
Patch Set 6: (4 inline comments)
The patch is a work in progress, more changes will come.
....................................................
File backend/manager/dbscripts/upgrade/pre_upgrade/0000_config.sql
Line 522:
Line 523: -- Device Custom Properties
Line 524: select fn_db_add_config_value('SupportCustomDeviceProperties',
'false', '3.0');
Line 525: select fn_db_add_config_value('SupportCustomDeviceProperties',
'false', '3.1');
Line 526: select fn_db_add_config_value('SupportCustomDeviceProperties',
'false', '3.2');
If I understand the concept, @DefaultValueAttribute("true") on
SupportCustomDeviceProperties attribute in ConfigValues class makes this select
unnecessary, so only unsupported version are needed to set value to false in db.
Line 527: select fn_db_add_config_value('CustomDeviceProperties', '', '3.3');
Line 528:
Line 529:
------------------------------------------------------------------------------------
Line 530: -- Update with override section
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AttachDiskToVmCommand.java
Line 137: true,
Line 138: getParameters().isPlugUnPlug(),
Line 139: false,
Line 140: "",
Line 141: null);
I'm not sure if this is correct, I added null just to compile the code. I will
have to investigate later.
Line 142: }
Line 143:
Line 144: protected void updateBootOrderInVmDevice() {
Line 145:
VmDeviceUtils.updateBootOrderInVmDeviceAndStoreToDB(getVm().getStaticData());
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/utils/VmDeviceUtils.java
Line 357: true,
Line 358: is_plugged,
Line 359: isReadOnly,
Line 360: "",
Line 361: null);
Sorry, I added it just to compile. I'm going to fix this in next patch with
CustomPropertiesUtils class will be implemented.
Line 362: dao.save(managedDevice);
Line 363: // If we add Disk/Interface/CD/Floppy, we have to recalculate
boot order
Line 364: if (type.equals(VmDeviceType.DISK) ||
type.equals(VmDeviceType.INTERFACE )) {
Line 365: // recalculate boot sequence
....................................................
File
backend/manager/modules/common/src/main/java/org/ovirt/engine/core/common/FeatureSupported.java
Line 63: /**
Line 64: * @param version
Line 65: * Compatibility version to check for.
Line 66: * @return <code>true</code> if get hardware information is
supported for the version, <code>false</code> if it's
Line 67: * not.
The word "not" is on a new line because of 120 character limit per line,
Eclipse did
this formatting, but it's based on our current formatting rules.
Line 68: */
Line 69: public static boolean hardwareInfo(Version version) {
Line 70: return supportedInConfig(ConfigValues.HardwareInfoEnabled,
version);
Line 71: }
--
To view, visit http://gerrit.ovirt.org/14309
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I67ed453706ac75cdc4356cc2d60913d8958c89ed
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Martin Peřina <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
