Alon Bar-Lev has posted comments on this change. Change subject: packaging: setup: added summary to engine-cleanup-2 ......................................................................
Patch Set 1: Looks good to me, but someone else must approve (1 inline comment) .................................................... File packaging/setup/plugins/ovirt-engine-remove/core/misc.py Line 94: ) Line 95: def _closeup(self): Line 96: self.dialog.note( Line 97: text=_( Line 98: 'Engine setup successfully cleaned up' For this?!?! I don't think it is needed, and if it is, it can be a simple log.info at the last priority of the core of cleanup... Line 99: ), Line 100: ) Line 101: -- To view, visit http://gerrit.ovirt.org/14701 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I894abbd6aab0e2840b164f7a361ed471a9edd961 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Sandro Bonazzola <[email protected]> Gerrit-Reviewer: Alex Lourie <[email protected]> Gerrit-Reviewer: Alon Bar-Lev <[email protected]> Gerrit-Reviewer: Ofer Schreiber <[email protected]> Gerrit-Reviewer: Sandro Bonazzola <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
