Alon Bar-Lev has posted comments on this change.
Change subject: db: drop the obfuscation of database password
......................................................................
Patch Set 1: (3 inline comments)
....................................................
File src/__main__.py
Line 179: else:
Line 180: raise Exception(stderr)
Line 181:
Line 182:
Line 183: class EngineConfigFile(object):
Maybe put this in different file? And import it?
Line 184: _COMMENT_EXPR = re.compile(r'\s*#.*$')
Line 185: _BLANK_EXPR = re.compile(r'^\s*$')
Line 186: _VALUE_EXPR =
re.compile(r'^\s*(?P<key>\w+)\s*=\s*(?P<value>.*?)\s*$')
Line 187: _REF_EXPR = re.compile(r'\$\{(?P<ref>\w+)\}')
Line 1205: pg_pass = engine_config.get('ENGINE_DB_PASSWORD')
Line 1206: pg_user = engine_config.get('ENGINE_DB_USER')
Line 1207: pg_dbname = engine_config.get('ENGINE_DB_DATABASE')
Line 1208: pg_dbhost = engine_config.get('ENGINE_DB_HOST')
Line 1209: pg_dbport = engine_config.get('ENGINE_DB_PORT')
I suggest this above logic go into function.
Line 1210:
Line 1211: DEFAULT_SCRATCH_DIR = tempfile.mkdtemp(prefix='logcollector-')
Line 1212:
Line 1213: commandline = set(sys.argv)
Line 1441: "",
Line 1442: "--pg-pass",
Line 1443: dest="pg_pass",
Line 1444: help=SUPPRESS_HELP,
Line 1445: default=pg_pass
I don't understand.. are you going to present the password to the user?
Line 1446: )
Line 1447:
Line 1448: db_group.add_option(
Line 1449: "", "--pg-dbname", dest="pg_dbname",
--
To view, visit http://gerrit.ovirt.org/14741
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I763f5a9d1d3307ee384281b13db5c6c9436060df
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
