Sandro Bonazzola has posted comments on this change.
Change subject: db: drop the obfuscation of database password
......................................................................
Patch Set 3: (3 inline comments)
....................................................
File src/__main__.py
Line 110: global pg_pass
Line 111: global pg_dbhost
Line 112: global pg_dbport
Line 113: global pg_dbname
Line 114: engine_config = utils.EngineConfigFile([config.ENGINE_CONF])
Done
Line 115: if engine_config.get('ENGINE_DB_PASSWORD'):
Line 116: pg_pass = engine_config.get('ENGINE_DB_PASSWORD')
Line 117: pg_user = engine_config.get('ENGINE_DB_USER')
Line 118: pg_dbname = engine_config.get('ENGINE_DB_DATABASE')
Line 1369: db_group.add_option(
Line 1370: "",
Line 1371: "--pg-pass",
Line 1372: dest="pg_pass",
Line 1373: help=SUPPRESS_HELP,
Removed default so the password will never be displayed in any case.
Line 1374: default=pg_pass
Line 1375: )
Line 1376:
Line 1377: db_group.add_option(
....................................................
File src/utils.py
Line 22: import os
Line 23: import re
Line 24:
Line 25:
Line 26: class EngineConfigFile(object):
Done
Line 27: _COMMENT_EXPR = re.compile(r'\s*#.*$')
Line 28: _BLANK_EXPR = re.compile(r'^\s*$')
Line 29: _VALUE_EXPR =
re.compile(r'^\s*(?P<key>\w+)\s*=\s*(?P<value>.*?)\s*$')
Line 30: _REF_EXPR = re.compile(r'\$\{(?P<ref>\w+)\}')
--
To view, visit http://gerrit.ovirt.org/14741
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I763f5a9d1d3307ee384281b13db5c6c9436060df
Gerrit-PatchSet: 3
Gerrit-Project: ovirt-log-collector
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Keith Robertson <[email protected]>
Gerrit-Reviewer: Kiril Nesenko <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
