Kanagaraj M has posted comments on this change.
Change subject: gluster: Fixing NPE in sync for empty cluster
......................................................................
Patch Set 1: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/gluster/GlusterHookSyncJob.java
Line 67: });
Line 68: }
Line 69: List<Pair<VDS, VDSReturnValue>> pairResults =
ThreadPoolUtil.invokeAll(taskList);
Line 70:
Line 71: addOrUpdateHooks(cluster.getId(), pairResults);
you could just enclose the method call itself inside a try+catch block instead
of enclosing the whole method content.
Line 72: }
Line 73: }
Line 74:
Line 75: private void addOrUpdateHooks(Guid clusterId, List<Pair<VDS,
VDSReturnValue>> pairResults ) {
--
To view, visit http://gerrit.ovirt.org/14740
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7e94a11f7550b7cf5d95b44edb7a8d30bf896db8
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sahina Bose <[email protected]>
Gerrit-Reviewer: Kanagaraj M <[email protected]>
Gerrit-Reviewer: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Shubhendu Tripathi <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
