Omer Frenkel has posted comments on this change.
Change subject: gluster: Added null check at couple of places
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/gluster/GlusterServicesReturnForXmlRpc.java
Line 45:
Line 46: private GlusterServerService getService(Map<String, Object>
serviceMap) {
Line 47: GlusterServerService serverService = new
GlusterServerService();
Line 48: serverService.setServiceName((String) serviceMap.get(NAME));
Line 49: String pid = (String) serviceMap.get(PID);
wouldnt it be nicer to use serviceMap.containsKey ?
Line 50: serverService.setPid(StringUtils.isEmpty(pid) ? null :
Integer.parseInt(pid));
Line 51: serverService.setStatus(GlusterServiceStatus.valueOf((String)
serviceMap.get(STATUS)));
Line 52: serverService.setMessage((String) serviceMap.get(MESSAGE));
Line 53: serverService.setServerId(serverId);
--
To view, visit http://gerrit.ovirt.org/14731
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If3c14530af6a1774274ebb537dcf14cda37c70e6
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Shireesh Anjal <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Sahina Bose <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
