Shahar Havivi has uploaded a new change for review. Change subject: findbugs: using SimpleDateFormat as static field is not thread safe ......................................................................
findbugs: using SimpleDateFormat as static field is not thread safe The field EXPECTED_DATE_FORMAT has no reason to be static, remove from ignore list Change-Id: Idb20bc905a048fa65e9e25abf3c6090ef356dfb1 Signed-off-by: Shahar Havivi <[email protected]> --- D backend/manager/modules/dal/exclude-filters.xml M backend/manager/modules/dal/pom.xml M backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java 3 files changed, 1 insertion(+), 31 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/72/14772/1 diff --git a/backend/manager/modules/dal/exclude-filters.xml b/backend/manager/modules/dal/exclude-filters.xml deleted file mode 100644 index 76522af..0000000 --- a/backend/manager/modules/dal/exclude-filters.xml +++ /dev/null @@ -1,19 +0,0 @@ -<FindBugsFilter> - <Match> - <Class name="org.ovirt.engine.core.dao.AuditLogDAOTest" /> - <Method name="setUp"/> - <Bug code="STCAL"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.core.dao.AuditLogDAOTest" /> - <Method name="testGetAllAfterDate"/> - <Bug code="STCAL"/> - </Match> - - <Match> - <Class name="org.ovirt.engine.core.dao.AuditLogDAOTest" /> - <Method name="testRemoveAllBeforeDate"/> - <Bug code="STCAL"/> - </Match> -</FindBugsFilter> diff --git a/backend/manager/modules/dal/pom.xml b/backend/manager/modules/dal/pom.xml index b80a874..7c951d7 100644 --- a/backend/manager/modules/dal/pom.xml +++ b/backend/manager/modules/dal/pom.xml @@ -202,17 +202,6 @@ <excludes/> </configuration> </plugin> - <plugin> - <groupId>org.codehaus.mojo</groupId> - <artifactId>findbugs-maven-plugin</artifactId> - <version>${findbugs.version}</version> - <configuration> - <xmlOutput>true</xmlOutput> - <!-- Optional directory to put findbugs xdoc xml report --> - <excludeFilterFile>exclude-filters.xml</excludeFilterFile> - <xmlOutputDirectory>target/site</xmlOutputDirectory> - </configuration> - </plugin> </plugins> </build> </profile> diff --git a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java index bd354ff..0a9ddf7 100644 --- a/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java +++ b/backend/manager/modules/dal/src/test/java/org/ovirt/engine/core/dao/AuditLogDAOTest.java @@ -33,7 +33,7 @@ private static final Guid VDS_ID = new Guid("afce7a39-8e8c-4819-ba9c-796d316592e6"); private static final long EXISTING_ENTRY_ID = 44291; private static final long EXTERNAL_ENTRY_ID = 44296; - private static final SimpleDateFormat EXPECTED_DATE_FORMAT = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); + private final SimpleDateFormat EXPECTED_DATE_FORMAT = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss"); private static final int FILTERED_COUNT = 5; private static final int TOTAL_COUNT = 6; -- To view, visit http://gerrit.ovirt.org/14772 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Idb20bc905a048fa65e9e25abf3c6090ef356dfb1 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Shahar Havivi <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
