ofri masad has posted comments on this change.
Change subject: core: Fix unauthorized move-disk
......................................................................
Patch Set 1: (1 inline comment)
quota permissions are added somewhere else (CommandBase: 921)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/AddVmCommand.java
Line 721: getActionType().getActionGroup()));
Line 722: if (getVmTemplate() != null &&
!getVmTemplate().getDiskList().isEmpty()) {
Line 723: for (DiskImage disk :
getParameters().getDiskInfoDestinationMap().values()) {
Line 724: if (disk.getStorageIds() != null &&
!disk.getStorageIds().isEmpty()) {
Line 725: permissionList.add(new
PermissionSubject(GuidUtils.getGuidValue(getStoragePoolId()),
correct
Line 726: VdcObjectType.Storage,
ActionGroup.CREATE_DISK));
Line 727: }
Line 728: }
Line 729: }
--
To view, visit http://gerrit.ovirt.org/14769
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I32713cbcf3206ab449ddca9b0ebd382bf77a7582
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: ofri masad <oma...@redhat.com>
Gerrit-Reviewer: Allon Mureinik <amure...@redhat.com>
Gerrit-Reviewer: Daniel Erez <de...@redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfedi...@redhat.com>
Gerrit-Reviewer: Gilad Chaplik <gchap...@redhat.com>
Gerrit-Reviewer: Laszlo Hornyak <lhorn...@redhat.com>
Gerrit-Reviewer: Moti Asayag <masa...@redhat.com>
Gerrit-Reviewer: ofri masad <oma...@redhat.com>
_______________________________________________
Engine-patches mailing list
Engine-patches@ovirt.org
http://lists.ovirt.org/mailman/listinfo/engine-patches
