Allon Mureinik has uploaded a new change for review. Change subject: core: Remove ResetVDSCommand ......................................................................
core: Remove ResetVDSCommand RemoveVDSCommand is not used anywhere in the codebase, and thus should be removed. Change-Id: I4ff6df24909835363bd473b9d833e78003bc07a0 Signed-off-by: Allon Mureinik <[email protected]> --- M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java D backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ResetVDSCommand.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java M backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java 4 files changed, 0 insertions(+), 32 deletions(-) git pull ssh://gerrit.ovirt.org:29418/ovirt-engine refs/changes/97/14797/1 diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java index 9837592..3a7a600 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/IVdsServer.java @@ -28,8 +28,6 @@ StatusOnlyReturnForXmlRpc hibernate(String vmId, String hiberVolHandle); - OneVmReturnForXmlRpc reset(String vmId); - OneVmReturnForXmlRpc resume(String vmId); VMListReturnForXmlRpc list(); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ResetVDSCommand.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ResetVDSCommand.java deleted file mode 100644 index 7e787eb..0000000 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/ResetVDSCommand.java +++ /dev/null @@ -1,16 +0,0 @@ -package org.ovirt.engine.core.vdsbroker.vdsbroker; - -import org.ovirt.engine.core.common.vdscommands.*; - -public class ResetVDSCommand<P extends VdsAndVmIDVDSParametersBase> extends VmReturnVdsBrokerCommand<P> { - public ResetVDSCommand(P parameters) { - super(parameters); - } - - @Override - protected void ExecuteVdsBrokerCommand() { - mVmReturn = getBroker().reset(mVmId.toString()); - ProceedProxyReturnValue(); - setReturnValue(VdsBrokerObjectsBuilder.buildVMDynamicData(mVmReturn.mVm)); - } -} diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java index 366dad2..30657a1 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerConnector.java @@ -14,8 +14,6 @@ public Map<String, Object> hibernate(String vmId, String hiberVolHandle); - public Map<String, Object> reset(String vmId); - public Map<String, Object> cont(String vmId); public Map<String, Object> list(); diff --git a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java index 25a1177..f13fd64 100644 --- a/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java +++ b/backend/manager/modules/vdsbroker/src/main/java/org/ovirt/engine/core/vdsbroker/vdsbroker/VdsServerWrapper.java @@ -95,18 +95,6 @@ } @Override - public OneVmReturnForXmlRpc reset(String vmId) { - try { - Map<String, Object> xmlRpcReturnValue = vdsServer.reset(vmId); - OneVmReturnForXmlRpc wrapper = new OneVmReturnForXmlRpc(xmlRpcReturnValue); - return wrapper; - } catch (UndeclaredThrowableException ute) { - throw new XmlRpcRunTimeException(ute); - } - - } - - @Override public OneVmReturnForXmlRpc resume(String vmId) { try { Map<String, Object> xmlRpcReturnValue = vdsServer.cont(vmId); -- To view, visit http://gerrit.ovirt.org/14797 To unsubscribe, visit http://gerrit.ovirt.org/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4ff6df24909835363bd473b9d833e78003bc07a0 Gerrit-PatchSet: 1 Gerrit-Project: ovirt-engine Gerrit-Branch: master Gerrit-Owner: Allon Mureinik <[email protected]> _______________________________________________ Engine-patches mailing list [email protected] http://lists.ovirt.org/mailman/listinfo/engine-patches
