Alon Bar-Lev has posted comments on this change.
Change subject: packaging: setup: added FQDN validation to engine-setup-2
......................................................................
Patch Set 10: Looks good to me, but someone else must approve
(2 inline comments)
OK, I am fine with this.
But I think that we should execute this special dig logic forward and reverse
only if the reverse validation is in place... but not that important.
....................................................
File packaging/setup/plugins/ovirt-engine-setup/config/protocols.py
Line 212: addresses=prettyString
Line 213: )
Line 214: )
Line 215: resolvedByDNS = self._resolvedByDNS(fqdn)
Line 216: source = ('DNS' if resolvedByDNS else _('host file'))
No need for the extra '(' ')' but not that important.
Line 217: #compare found IP with list of local IPs and match.
Line 218: if not resolvedAddresses.issubset(ipAddresses):
Line 219: raise RuntimeError(
Line 220: _(
Line 226: addresses=prettyString
Line 227: )
Line 228: )
Line 229:
Line 230: if not resolvedByDNS:
I think this can also be moved for the
self.environment[osetupcons.ConfigEnv.FQDN_REVERSE_VALIDATION]...
So we actually running dig only in this case, and behave as any decent
application if not.
Line 231: self.logger.warning(
Line 232: _(
Line 233: 'Failed to resolve {fqdn} using DNS, '
Line 234: 'it can be resolved only locally'
--
To view, visit http://gerrit.ovirt.org/14699
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie9764f32ba5e30062532bf11c67756677333c44f
Gerrit-PatchSet: 10
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Alex Lourie <[email protected]>
Gerrit-Reviewer: Alon Bar-Lev <[email protected]>
Gerrit-Reviewer: Ofer Schreiber <[email protected]>
Gerrit-Reviewer: Sandro Bonazzola <[email protected]>
Gerrit-Reviewer: Yedidyah Bar David <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
