Maor Lipchuk has posted comments on this change.
Change subject: core: move image group command
......................................................................
Patch Set 6: (3 inline comments)
Partial reviewed
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/MoveImageGroupCommand.java
Line 25: removeImageParams.setEntityId(Guid.NewGuid());
Line 26: removeImageParams.setParentCommand(VdcActionType.RemoveImage);
Line 27:
removeImageParams.setDbOperationScope(ImageDbOperationScope.NONE);
Line 28: //TODO: should be removed as async task manager issues would
be resolved, done in order
Line 29: // to avoid copy operations on the image to wait for remove
operations.
Not necessary any more?
Line 30: removeImageParams.setEntityId(Guid.NewGuid());
Line 31: VdcReturnValueBase returnValue =
getBackend().runInternalAction(
Line 32: VdcActionType.RemoveImage,
Line 33: removeImageParams,
Line 26: removeImageParams.setParentCommand(VdcActionType.RemoveImage);
Line 27:
removeImageParams.setDbOperationScope(ImageDbOperationScope.NONE);
Line 28: //TODO: should be removed as async task manager issues would
be resolved, done in order
Line 29: // to avoid copy operations on the image to wait for remove
operations.
Line 30: removeImageParams.setEntityId(Guid.NewGuid());
No need to set the entity id twice (see line 25)
Also I think there should be a comment what this entity id is used for
Line 31: VdcReturnValueBase returnValue =
getBackend().runInternalAction(
Line 32: VdcActionType.RemoveImage,
Line 33: removeImageParams,
Line 34:
ExecutionHandler.createDefaultContexForTasks(getExecutionContext()));
Line 56: logable.addCustomValue("DiskAlias",
getDiskImage().getDiskAlias());
Line 57: logable.addCustomValue("StorageDomainName",
getStorageDomain().getStorageName());
Line 58: logable.addCustomValue("UserName", getUserName());
Line 59: AuditLogType logType = null;
Line 60: if (getActionState() == CommandActionState.END_SUCCESS) {
The audit log is a bit confusing (printing failure when get action success) I
would add a comment here explain why we do that.
Line 61: logType =
AuditLogType.USER_MOVE_IMAGE_GROUP_FAILED_TO_DELETE_SRC_IMAGE;
Line 62: } else {
Line 63: logType =
AuditLogType.USER_MOVE_IMAGE_GROUP_FAILED_TO_DELETE_DST_IMAGE;
Line 64: }
--
To view, visit http://gerrit.ovirt.org/13042
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id9068d66df3986c9bb16b266bb5bef396964a706
Gerrit-PatchSet: 6
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Ayal Baron <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
