Tal Nisan has posted comments on this change.
Change subject: core: FQCN imports in the bll project
......................................................................
Patch Set 1: Looks good to me, approved
(2 inline comments)
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/GetAllServerCpuListQuery.java
Line 1: package org.ovirt.engine.core.bll;
Line 2:
Line 3: import
org.ovirt.engine.core.common.queries.GetAllServerCpuListParameters;
Line 4:
Line 5: //class CanDoActionQuery : QueriesCommandBase
Not a must but this comment part is not relevant for years now, can be removed
Line 6: //{
Line 7: // internal CanDoActionQuery(CanDoActionParameters parameters)
Line 8: // : base(parameters)
Line 9: // {
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/PowerSaveComparer.java
Line 3: import org.ovirt.engine.core.common.businessentities.VDS;
Line 4: import org.ovirt.engine.core.common.businessentities.VM;
Line 5:
Line 6: /**
Line 7: * Algorithm. For server with desktops and server without desktop
server with
Hehe
Line 8: * desktops will be chosen. For 2 servers with desktops server with less
Line 9: * desktops will be chosen.
Line 10: */
Line 11: public class PowerSaveComparer extends EvenlyDistributeComparer {
--
To view, visit http://gerrit.ovirt.org/14805
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I988e31a8e2c5eae783d528dab16dbdf356aef260
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alissa Bonas <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Daniel Erez <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Maor Lipchuk <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Oved Ourfali <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Sergey Gotliv <[email protected]>
Gerrit-Reviewer: Tal Nisan <[email protected]>
Gerrit-Reviewer: Vered Volansky <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
