Yair Zaslavsky has posted comments on this change.
Change subject: core: Moves VmPropertiesUtils to CustomPropetiesUtils
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/customprop/CustomPropertiesUtils.java
Line 24: * Helper methods to help parse and validate custom VM (predefined and
user defined) and device properties. These
Line 25: * methods are used by vdsbroker and bll modules
Line 26: *
Line 27: */
Line 28: public class CustomPropertiesUtils {
what method will expose the map of custom properties to the VDS commands?
(For example - for "Create" - getVMProperties will return the required map.
Bare in mind we need to think about Disk and Nic here.
Line 29:
Line 30: private static CustomPropertiesUtils vmPropertiesUtils = null;
Line 31:
Line 32: public static CustomPropertiesUtils getInstance() {
--
To view, visit http://gerrit.ovirt.org/14813
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib18a622a1d02f444c6bdc1e22c2f92f93c52757e
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
