Yair Zaslavsky has posted comments on this change.
Change subject: core: reduce compensation scope from hibernate command
......................................................................
Patch Set 5: Looks good to me, approved
(2 inline comments)
Based on Omer +1, and my review - giving +2.
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/CommandBase.java
Line 1288: protected Guid
createTaskInCurrentTransaction(AsyncTaskCreationInfo asyncTaskCreationInfo,
Line 1289: VdcActionType parentCommand,
Line 1290: VdcObjectType entityType,
Line 1291: Guid... entityIds) {
Line 1292: return createTaskImpl(asyncTaskCreationInfo, parentCommand,
null, entityType, entityIds);
Agreed
Line 1293: }
Line 1294:
Line 1295: /**
Line 1296: * Use this method in order to create task in the
AsyncTaskManager in a safe way. If you use this method within a
....................................................
File
backend/manager/modules/bll/src/main/java/org/ovirt/engine/core/bll/HibernateVmCommand.java
Line 137: if (!ret1.getSucceeded()) {
Line 138: return;
Line 139: }
Line 140:
Line 141: Guid guid1 = TransactionSupport.executeInNewTransaction(
Agreed, especially due to backport issue.
Line 142: new TransactionMethod<Guid>() {
Line 143: @Override
Line 144: public Guid runInTransaction() {
Line 145:
getCompensationContext().resetCompensation();
--
To view, visit http://gerrit.ovirt.org/14510
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iec46798fc6ea01ef6b0b4701e1af5ba616edf910
Gerrit-PatchSet: 5
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Arik Hadas <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Liron Ar <[email protected]>
Gerrit-Reviewer: Michael Kublin <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Ravi Nori <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
