Yair Zaslavsky has posted comments on this change.
Change subject: core: Changes type of VmDevice from String to enum
......................................................................
Patch Set 1: (1 inline comment)
....................................................
File
backend/manager/modules/utils/src/main/java/org/ovirt/engine/core/utils/ovf/OvfWriter.java
Line 22: import org.ovirt.engine.core.compat.Version;
Line 23: import org.ovirt.engine.core.compat.backendcompat.XmlDocument;
Line 24: import org.ovirt.engine.core.compat.backendcompat.XmlTextWriter;
Line 25:
Line 26: public abstract class OvfWriter implements IOvfBuilder {
Adding this as inline comment -
We need to support customProperties export/import (for vm and template).
Line 27: protected int _instanceId;
Line 28: protected List<DiskImage> _images;
Line 29: protected XmlTextWriter _writer;
Line 30: protected XmlDocument _document;
--
To view, visit http://gerrit.ovirt.org/14812
To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Icada39e3918fb053cb0ad0388178ccf5c6338ca2
Gerrit-PatchSet: 1
Gerrit-Project: ovirt-engine
Gerrit-Branch: master
Gerrit-Owner: Martin Peřina <[email protected]>
Gerrit-Reviewer: Allon Mureinik <[email protected]>
Gerrit-Reviewer: Alona Kaplan <[email protected]>
Gerrit-Reviewer: Arik Hadas <[email protected]>
Gerrit-Reviewer: Eli Mesika <[email protected]>
Gerrit-Reviewer: Michal Skrivanek <[email protected]>
Gerrit-Reviewer: Moti Asayag <[email protected]>
Gerrit-Reviewer: Omer Frenkel <[email protected]>
Gerrit-Reviewer: Roy Golan <[email protected]>
Gerrit-Reviewer: Yair Zaslavsky <[email protected]>
_______________________________________________
Engine-patches mailing list
[email protected]
http://lists.ovirt.org/mailman/listinfo/engine-patches
